[ENH] Feature Statistics: Move from prototypes to core #3303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Could you include the documentation as well? Thanks! |
pavlin-policar
force-pushed
the
feature-statistics
branch
from
ae66122
to
b65cf30
Compare
Codecov Report
@@ Coverage Diff @@
## master #3303 +/- ##
==========================================
+ Coverage 82.25% 82.34% +0.08%
==========================================
Files 351 354 +3
Lines 62450 63244 +794
==========================================
+ Hits 51371 52080 +709
- Misses 11079 11164 +85 |
pavlin-policar
force-pushed
the
feature-statistics
branch
3 times, most recently
from
6032752
to
020c67b
Compare
pavlin-policar
force-pushed
the
feature-statistics
branch
from
3b05dee
to
deb1a0f
Compare
|
Are we waiting to stop testing on Py3.4 to merge this one? I see only tests for Py3.4 are failing. Then we should probably wait for tests to pass on 3.7, no? |
|
Yes, this doesn't work with Python 3.4, once it's removed from CI, this can be merged. |
pavlin-policar
force-pushed
the
feature-statistics
branch
from
deb1a0f
to
b496cab
Compare
lanzagar
changed the title
|
Python 3.4 was removed from travis testing, but tests still fail on python 3.5 with PyQt4. |
pavlin-policar
force-pushed
the
feature-statistics
branch
from
3370cc8
to
fd02b69
Compare
pavlin-policar
force-pushed
the
feature-statistics
branch
from
fd02b69
to
eb4c6f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
biolab/orange3-prototypes#165
Description of changes
Move Feature Statistics widget to core.
Includes