[ENH] Correlations: Enhancements and fixes #3660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VesnaT
changed the title
Codecov Report
@@ Coverage Diff @@
## master #3660 +/- ##
==========================================
+ Coverage 84.33% 84.35% +0.01%
==========================================
Files 370 370
Lines 67896 67940 +44
==========================================
+ Hits 57263 57309 +46
+ Misses 10633 10631 -2 |
Generate all possible attribute pairs, starting with pairs within clusters, followed by pairs among clusters.
VesnaT
force-pushed
the
correlations_heuristic
branch
from
1b0a16d
to
6c363cd
Compare
janezd
reviewed
Mar 7, 2019
| @@ -206,9 +218,11 @@ class Outputs: | |||
| correlation_type = Setting(0) | |||
|
|
|||
| class Information(OWWidget.Information): | |||
| removed_cons_feat = Msg("Constant features have been removed.") | |||
|
|
|||
| class Warning(OWWidget.Warning): | |||
| not_enough_vars = Msg("Need at least two continuous features.") | |||
| not_enough_inst = Msg("Need at least two instances.") | |||
There was a problem hiding this comment.
Could we make these messages proper sentences?
janezd
reviewed
Mar 8, 2019
| instances = None # type: Optional[List] | ||
| centroid = None # type: Optional[np.ndarray] | ||
|
|
||
|
|
||
| class KMeansCorrelationHeuristic: | ||
| """ | ||
| Heuristic to obtain the most promising attribute pairs, when there are to |
There was a problem hiding this comment.
to -> too
(not important, skip if you don't make any other, substantial changes)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Implements the last part of #3504.
Description of changes
Need at least two continuous features.andNeed at least two instances.messages as warningsIncludes