[FIX] OWTable: Don't set selection when there is no data on input #3693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3693 +/- ##
==========================================
- Coverage 84.52% 84.51% -0.01%
==========================================
Files 373 373
Lines 68391 68393 +2
==========================================
Hits 57805 57805
- Misses 10586 10588 +2 |
|
This fixes the symptom, but the real problem is that selection is non-empty although there is no data. Such state is invalid and may cause other problems elsewhere in the widget. Could you investigate why this happens and how to prevent it? |
rokgomiscek
force-pushed
the
owtable-fix
branch
from
043af47
to
2e344fc
Compare
|
I think this now fixes the problem. The old selection was stored in __pending_selected_rows and __pending_selected_cols, which were used to restore selected_rows and selected_cols respectively. My previous fix didn't empty the selections, only didn't pass it forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #3451.
Description of changes
Fixes the bug by adding an additional check.
Includes