Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] OWPythagorasTree: Enable node selection from forests with categorical variables. #3775

Merged
merged 3 commits into from
May 17, 2019

Conversation

thocevar
Copy link
Contributor

Issue

Fixes #3414

Description of changes

Transform data to the discretized domain when computing the samples in leaves (SklTreeAdapter).

Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Apr 26, 2019

Codecov Report

Merging #3775 into master will increase coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3775      +/-   ##
==========================================
+ Coverage   84.98%   85.04%   +0.05%     
==========================================
  Files         374      374              
  Lines       69114    69094      -20     
==========================================
+ Hits        58738    58762      +24     
+ Misses      10376    10332      -44

Copy link
Collaborator

@pavlin-policar pavlin-policar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the crash. You also figured out why the tooltips are wrong for the random forest trees, but I suppose that belongs in a separate PR.

Orange/widgets/visualize/utils/tree/skltreeadapter.py Outdated Show resolved Hide resolved
@pavlin-policar
Copy link
Collaborator

I hate to be annoying, but this test really belongs to the tree widget tests, not the forest widget tests. If the behaviour is in the tree widget, the tests should be added to the tree widget tests. Otherwise, the tests for the forest widget are also testing the tree widget, which would quickly become messy.

@pavlin-policar pavlin-policar merged commit ccd8a40 into biolab:master May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pythagorean Tree crashes when selecting data with categorical variables
3 participants