[FIX] VerticalItemDelegate: Do not cut long vertical labels #3803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3803 +/- ##
==========================================
- Coverage 85.06% 85.06% -0.01%
==========================================
Files 374 374
Lines 69143 69148 +5
==========================================
+ Hits 58817 58820 +3
- Misses 10326 10328 +2 |
|
This seems OK for this particular use case because there is nothing in the cell above and below this one. What if they are not empty? Maybe |
VesnaT
force-pushed
the
VerticalItemDelegate
branch
from
b518f06
to
102a2c5
Compare
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Long vertical labels (i.e. labels for table's vertical header) are cut off:
Description of changes
Show the whole label.
Includes