Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] OWRadviz: legible axis labels #3809

Merged
merged 3 commits into from
Jun 7, 2019

Conversation

robertcv
Copy link
Collaborator

Issue

Fixes #3744

Description of changes
  • Rotate variable labels according to the angel of position
  • Shorten labels to 20 characters
  • Show tooltip with the full label name
  • Limit number of selected variables to 20

radviz

Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented May 20, 2019

Codecov Report

Merging #3809 into master will decrease coverage by <.01%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master    #3809      +/-   ##
==========================================
- Coverage   84.77%   84.76%   -0.01%     
==========================================
  Files         374      374              
  Lines       69172    69198      +26     
==========================================
+ Hits        58640    58658      +18     
- Misses      10532    10540       +8

@BlazZupan
Copy link
Contributor

In case of longer, multi-word labels, there is sufficient place to split the labels to, say, two lines, and end the label with ellipsis where there is an end of the word.

For example, we could split "Gross national income (GNI) per capita" into

Gross national
income (GNI) ...

or "Estimated gross national income per capita" into

Estimated
gross national ...

In this way the width of the labels can get short her. Currently, and in the example above, labels take much space making the graph smaller.

Display of full text of the label when mouse-over is great and it should of course stay.

* rotate variable labels
* shorten labels to 20 characters
* add tooltip for labels
* limit number of selected variables
@robertcv
Copy link
Collaborator Author

I add the split. Is it ok?
Screenshot from 2019-05-31 13-00-15

@BlazZupan
Copy link
Contributor

This looks way better. Another tiny request for change, though, before closing this PR: if the text appears on the left side of the circle than it should be right-aligned. This was irrelevant for the one-liners before. For instance, in the example above, "Gender development" on the bottom left should be right aligned. If this change is not difficult to make, please revise the PR.

@robertcv
Copy link
Collaborator Author

robertcv commented Jun 7, 2019

Screenshot from 2019-06-07 13-59-19

@BlazZupan BlazZupan merged commit d672ab7 into biolab:master Jun 7, 2019
@robertcv robertcv deleted the fix/radviz_labels branch November 19, 2019 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OWRadViz: legible axis labels
2 participants