[FIX] condainstall: Fix env for running conda #3843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'CONDA_BAT' env variable is used by conda for running/activating scripts. Since conda 4.6.9, the use here breaks the subsequent post link scripts in package installs. Fix by moving all the extra env modifications to the end of the script.
|
Patched installer |
Codecov Report
@@ Coverage Diff @@
## master #3843 +/- ##
==========================================
- Coverage 84.94% 84.94% -0.01%
==========================================
Files 376 376
Lines 70159 70159
==========================================
- Hits 59596 59594 -2
- Misses 10563 10565 +2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes gh-3819
'CONDA_BAT' env variable is used by conda for running/activating scripts. Since conda 4.6.9, the use here breaks the subsequent post link scripts in package installs.
Description of changes
Move all the extra env modifications to the end of the script.
Includes