[FIX] DistMatrix should return numpy datatypes #3865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertcv
force-pushed
the
fix/distmatrix_datatype
branch
from
7ca69e1
to
5859fc8
Compare
Codecov Report
@@ Coverage Diff @@
## master #3865 +/- ##
=========================================
Coverage ? 84.95%
=========================================
Files ? 378
Lines ? 70377
Branches ? 0
=========================================
Hits ? 59791
Misses ? 10586
Partials ? 0 |
Codecov Report
@@ Coverage Diff @@
## master #3865 +/- ##
=======================================
Coverage 84.96% 84.96%
=======================================
Files 378 378
Lines 70459 70459
=======================================
Hits 59868 59868
Misses 10591 10591 |
robertcv
force-pushed
the
fix/distmatrix_datatype
branch
2 times, most recently
from
7959e99
to
0d029ec
Compare
robertcv
force-pushed
the
fix/distmatrix_datatype
branch
from
0d029ec
to
1fd6a65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #3658
Due to DistMatrix.max() returning Python int objects, numpy functions like np.testing.assert_array_equal fail unexpectedly.
Description of changes
When returning zero dimensional array use indexing to get a numpy datatype.
Includes