Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Variable.make #3925

Merged
merged 18 commits into from
Sep 20, 2019
Merged

Remove Variable.make #3925

merged 18 commits into from
Sep 20, 2019

Commits on Sep 17, 2019

  1. Remove Variable.make 

    Two variables are equal if they have the same name, type and compute value. Hash works accordingly. Discrete variables provide mappers, which are used by models to map back to the "testing" data class.

This solution may cause least problems because two variables are now equal in the same case as when make would reuse a variable.
    @janezd
    janezd committed Sep 17, 2019
    Configuration menu
    Copy the full SHA
    5f650da View commit details
    Browse the repository at this point in the history

  2. Variable: Deprecated _clear_all_caches; remove calls from code

    @janezd
    janezd committed Sep 17, 2019
    Configuration menu
    Copy the full SHA
    2c00469 View commit details
    Browse the repository at this point in the history

  3. Removal of Variable.make: Further fixes in base classes

    @janezd
    janezd committed Sep 17, 2019
    Configuration menu
    Copy the full SHA
    0701b96 View commit details
    Browse the repository at this point in the history

  4. Removal of Variable.make: Fix OWPredictions

    @janezd
    janezd committed Sep 17, 2019
    Configuration menu
    Copy the full SHA
    d6fe394 View commit details
    Browse the repository at this point in the history

  5. Removal of Variable.make: Fix tests

    @janezd
    janezd committed Sep 17, 2019
    Configuration menu
    Copy the full SHA
    5d17081 View commit details
    Browse the repository at this point in the history

  6. Removal of Variable.make: Fix a few anonymous variables

    @janezd
    janezd committed Sep 17, 2019
    Configuration menu
    Copy the full SHA
    84143d4 View commit details
    Browse the repository at this point in the history

  7. Removal of Variable.make: Fix mapping in classifiers

    @janezd
    janezd committed Sep 17, 2019
    Configuration menu
    Copy the full SHA
    e01abf9 View commit details
    Browse the repository at this point in the history

  8. Removal of Variable.make: Remove compute_value in unused_values

    @janezd
    janezd committed Sep 17, 2019
    Configuration menu
    Copy the full SHA
    b10f57a View commit details
    Browse the repository at this point in the history

  9. Removal of Variable.make: Fix tests

    @janezd
    janezd committed Sep 17, 2019
    Configuration menu
    Copy the full SHA
    0e47e1e View commit details
    Browse the repository at this point in the history

  10. Removal of Variable.make: Fix Table conversion

    @janezd
    janezd committed Sep 17, 2019
    Configuration menu
    Copy the full SHA
    a8cea64 View commit details
    Browse the repository at this point in the history

  11. Removal of Variable.make: Properly handle multitarget models

    @janezd
    janezd committed Sep 17, 2019
    Configuration menu
    Copy the full SHA
    8a6b895 View commit details
    Browse the repository at this point in the history

  12. Removal of Variable.make: Support classless models

    @janezd
    janezd committed Sep 17, 2019
    Configuration menu
    Copy the full SHA
    50bcb49 View commit details
    Browse the repository at this point in the history

  13. Removal of Variable.make: Add tests for mapper; Improve mapping of sp… 

    …arse data
    @janezd
    janezd committed Sep 17, 2019
    Configuration menu
    Copy the full SHA
    01786c1 View commit details
    Browse the repository at this point in the history

  14. Removal of Variable.make: Add more tests + a fix in mapping probabili… 

    …ties
    @janezd
    janezd committed Sep 17, 2019
    Configuration menu
    Copy the full SHA
    50efd87 View commit details
    Browse the repository at this point in the history

  15. Removal of Variable.make: _get_equivalent in O(1)

    @markotoplak @janezd
    markotoplak authored and janezd committed Sep 17, 2019
    Configuration menu
    Copy the full SHA
    557adb0 View commit details
    Browse the repository at this point in the history

  16. Removal of Variable.make: use == instead of is for equality of `c… 

    …ompute_value`
    @janezd
    janezd committed Sep 17, 2019
    Configuration menu
    Copy the full SHA
    f095bef View commit details
    Browse the repository at this point in the history

  17. Removal of Variable.make: expose methods for backmappers in Model

    @janezd
    janezd committed Sep 17, 2019
    Configuration menu
    Copy the full SHA
    cb57353 View commit details
    Browse the repository at this point in the history

  18. Removal of Variable.make: Change Predictions to accept different models

    @janezd
    janezd committed Sep 17, 2019
    Configuration menu
    Copy the full SHA
    ecbcd3f View commit details
    Browse the repository at this point in the history