[FIX] Fix storing and retrieving selection, and unconditional auto commit #3957
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3957 +/- ##
==========================================
+ Coverage 85.42% 85.47% +0.05%
==========================================
Files 385 385
Lines 68873 69007 +134
==========================================
+ Hits 58832 58986 +154
+ Misses 10041 10021 -20 |
janezd
force-pushed
the
retain-selection
branch
from
21e7f57
to
6dddb3b
Compare
janezd
changed the title
janezd
force-pushed
the
retain-selection
branch
3 times, most recently
from
2dc4f0e
to
9145e74
Compare
janezd
force-pushed
the
retain-selection
branch
from
9145e74
to
5afd276
Compare
|
On Travis on Python 3.7 this |
Orange/widgets/visualize/owmosaic.py
Outdated
| @@ -442,6 +443,7 @@ def set_data(self, data): | |||
|
|
|||
| self.init_combos(self.data) | |||
| self.openContext(self.data) | |||
| self.__pending_selection = self.selection | |||
There was a problem hiding this comment.
Shouldn't this be a 'schema only' setting?
| @@ -76,6 +76,8 @@ class Outputs: | |||
| add_scores = settings.Setting(False) | |||
| auto_commit = settings.Setting(True) | |||
|
|
|||
| pending_selection = settings.ContextSetting(None, schema_only=True) | |||
There was a problem hiding this comment.
I think we have not handled 'schema only' context settings, so setting the flag to True has no effect.
janezd
force-pushed
the
retain-selection
branch
3 times, most recently
from
1dc4880
to
fc22065
Compare
| self.set_color_data() | ||
| self.reset_graph() | ||
| self.update_graph() | ||
| self.send_selection() |
There was a problem hiding this comment.
@VesnaT, copying from projection widget indeed helped (and you were right about not using pack_settings, I should have listened more carefully and be less self confident :)).
However, every widget has also its own tricks, so you can't just copy. In this case, it was important to call send_selection after update_graph.
janezd
force-pushed
the
retain-selection
branch
from
fc22065
to
278caca
Compare
Fixes #3762. Fixes #3763.
Following @markotoplak suggestion, instance selections are schema-only because data is not a part of the context.