[FIX] Correlations: Add progress bar, retain responsiveness #4011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VesnaT
force-pushed
the
correlations_progress_bar
branch
2 times, most recently
from
0fa9a8b
to
a8a6c7f
Compare
Codecov Report
@@ Coverage Diff @@
## master #4011 +/- ##
==========================================
+ Coverage 85.38% 85.39% +<.01%
==========================================
Files 385 385
Lines 68659 68710 +51
==========================================
+ Hits 58625 58675 +50
- Misses 10034 10035 +1 |
VesnaT
changed the title
VesnaT
force-pushed
the
correlations_progress_bar
branch
from
18c4570
to
3619455
Compare
VesnaT
changed the title
VesnaT
changed the title
VesnaT
force-pushed
the
correlations_progress_bar
branch
from
b5aa2a2
to
d69bdd2
Compare
VesnaT
force-pushed
the
correlations_progress_bar
branch
from
d69bdd2
to
7a52bc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #4008
Since adding the progress bar was somehow trivial, making the widget responsive was not and I'm still not sure about the solution.
The widget was getting unresponsive for datasets with small number of instances and many features. In those cases correlation between a pair of features was calculated 'too fast' which caused a signal, for setting partial results, being emitted too frequently. Consequently the widget was getting unresponsive.
Description of changes
To prevent the congestion, the signal is only emitted every 0.01 second.
Includes