[ENH] Test & Score Widget: Cancellability on input change. #4079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ales-erjavec
changed the title
Codecov Report
@@ Coverage Diff @@
## master #4079 +/- ##
==========================================
- Coverage 85.95% 85.95% -0.01%
==========================================
Files 393 394 +1
Lines 70128 70146 +18
==========================================
+ Hits 60277 60292 +15
- Misses 9851 9854 +3 |
ales-erjavec
force-pushed
the
output-invalidate
branch
from
4d88e7e
to
5e946a4
Compare
ales-erjavec
force-pushed
the
output-invalidate
branch
3 times, most recently
from
4c9e5a8
to
e66c2b7
Compare
ales-erjavec
force-pushed
the
output-invalidate
branch
5 times, most recently
from
9784e16
to
e1418e2
Compare
ales-erjavec
force-pushed
the
output-invalidate
branch
2 times, most recently
from
04ecd24
to
cb8b99e
Compare
Cleanup cancellation
Allow interruption on input change
ales-erjavec
force-pushed
the
output-invalidate
branch
from
cb8b99e
to
5ad7956
Compare
ales-erjavec
force-pushed
the
output-invalidate
branch
from
5ad7956
to
0b58951
Compare
ales-erjavec
changed the title
|
I (and everybody else) will have to study these widgets to learn how to use your mixins for threads instead of writing our own questionable code and then desparately ask you for help. I noticed one glitch. I ran leave one out with logistic regression on adult. I removed the Logistic regression widget. Testing stops, but the widget status is still shown as "Running", though without progress indication and percentages.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes gh-4028
Requires:
Description of changes
Remove use of input blocking 'blocking' state in favor of non-blocking output invalidation.
Includes