[FIX] Datetime conversion to string #4098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4098 +/- ##
=======================================
Coverage 85.56% 85.56%
=======================================
Files 385 385
Lines 69220 69220
=======================================
Hits 59228 59228
Misses 9992 9992 |
lanzagar
reviewed
Oct 11, 2019
Orange/widgets/utils/domaineditor.py
Outdated
Comment on lines
325
to
327
| elif type(orig_var) == TimeVariable: | ||
| col_data = [orig_var.repr_val(x) if not np.isnan(x) else "" | ||
| for x in self._iter_vals(col_data)] |
There was a problem hiding this comment.
This looks to be the same as in the above if type(orig_var) == DiscreteVariable,
we could change the first check to match both types, e.g. if type(orig_var) in (DiscreteVariable, TimeVariable),
so we can avoid copy/pasting code.
There was a problem hiding this comment.
Makes sense. Changed.
rokgomiscek
force-pushed
the
datetime_string_conversion
branch
from
26f83d4
to
daee584
Compare
janezd
pushed a commit
to janezd/orange3
that referenced
this pull request
Oct 18, 2019
…rsion [FIX] Datetime conversion to string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #3963
Description of changes
Added additional branch when converting to string.
Includes