[ENH] MergeData: Don't remove duplicate columns with different data #4100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janezd
force-pushed
the
merge-data-non-duplicate
branch
from
14b22c6
to
e8e672f
Compare
Codecov Report
@@ Coverage Diff @@
## master #4100 +/- ##
==========================================
+ Coverage 85.68% 85.69% +0.01%
==========================================
Files 390 390
Lines 69732 69796 +64
==========================================
+ Hits 59750 59812 +62
- Misses 9982 9984 +2 |
janezd
force-pushed
the
merge-data-non-duplicate
branch
2 times, most recently
from
549eed9
to
3f935f9
Compare
|
There is a bug. Could had been there before the PR, but can you please check anyway.
The scariest thing here is, all the tests passed. |
janezd
force-pushed
the
merge-data-non-duplicate
branch
from
3f935f9
to
3d0787a
Compare
vstack of Y failed when all output rows were matched and the output had a single class variable. i
|
Interesting. Yes, it was unrelated to changes in this PR. I fixed it and wrote a test that would fail without the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4077.
Includes