[FIX] File widget: fix name change #4235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4235 +/- ##
==========================================
+ Coverage 86.03% 86.04% +0.01%
==========================================
Files 394 394
Lines 70169 70200 +31
==========================================
+ Hits 60369 60404 +35
+ Misses 9800 9796 -4 |
janezd
changed the title
PrimozGodec
force-pushed
the
enable-var-name-change
branch
from
1204e92
to
82f1032
Compare
PrimozGodec
changed the title
|
@janezd it is ready now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
File widget fails on an attribute name change. It happens just in cases when only the name is changed and the type of variable stays the same.
Description of changes
Fixed name change using the copy function. It seems that the variable name is protected (no setter function).
Includes