[FIX] Give created QGraphicsScenes a parent #4352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ales-erjavec
force-pushed
the
fixes/qgraphicsscene-parent
branch
from
c73796d
to
ebed764
Compare
Codecov Report
@@ Coverage Diff @@
## master #4352 +/- ##
==========================================
- Coverage 83.61% 83.59% -0.02%
==========================================
Files 281 276 -5
Lines 56189 55384 -805
==========================================
- Hits 46982 46301 -681
+ Misses 9207 9083 -124 |
ales-erjavec
force-pushed
the
fixes/qgraphicsscene-parent
branch
2 times, most recently
from
9b65b59
to
491b8a2
Compare
ales-erjavec
force-pushed
the
fixes/qgraphicsscene-parent
branch
2 times, most recently
from
27fe548
to
ce74a81
Compare
ales-erjavec
force-pushed
the
fixes/qgraphicsscene-parent
branch
from
ce74a81
to
bd72e64
Compare
Ensure the scene is deleted at the same time as the widget. Fix an runtime error at process exit when running tests with PyQt 5.14
ales-erjavec
force-pushed
the
fixes/qgraphicsscene-parent
branch
from
bd72e64
to
0eb66bc
Compare
ales-erjavec
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Ref gh-4284
Fix an runtime error at process exit
Will require biolab/orange-widget-base#37 to be merged and released
Description of changes
Enable testing on PyQt5 5.14(test still segfault with PyQt5 5.14 at process exit)Includes