[ENH] Heatmap: Tighter layout #4390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4390 +/- ##
==========================================
+ Coverage 87.18% 87.19% +<.01%
==========================================
Files 401 401
Lines 72938 72934 -4
==========================================
Hits 63592 63592
+ Misses 9346 9342 -4 |
Negative max size is invalid and could cause a possbile endless loop in QGraphicsGridLayout.
Prior to Qt 5.4 hidden QGraphicsWidgets retained their size in the layout.
ales-erjavec
force-pushed
the
heatmap-layout-aspect
branch
from
c80b864
to
a63c8c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Ref gh-4380
Description of changes
Includes