[FIX] graphicstextlist: Use integer font metrics again #4524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QGraphicsSimpleTextItem uses ceiled line heights in its bounding rect estimation. Use integer metrics to layout the items.
Codecov Report
@@ Coverage Diff @@
## master #4524 +/- ##
==========================================
- Coverage 83.29% 83.26% -0.03%
==========================================
Files 279 274 -5
Lines 55656 54851 -805
==========================================
- Hits 46357 45671 -686
+ Misses 9299 9180 -119 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Ref: #4519 (comment)
Description of changes
QGraphicsSimpleTextItem uses ceiled line heights in its bounding rect
estimation. Use integer metrics to layout the items.
Includes