[ENH] Ignore missing values in density plots of projections #4525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janezd
changed the title
Codecov Report
@@ Coverage Diff @@
## master #4525 +/- ##
==========================================
+ Coverage 83.34% 83.35% +0.01%
==========================================
Files 274 274
Lines 54906 54955 +49
==========================================
+ Hits 45760 45810 +50
+ Misses 9146 9145 -1 |
janezd
force-pushed
the
densities-of-known
branch
from
1ccb2a1
to
6a6d699
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4503.
Issue
With many missing values, density plots get ugly. Missing values should be ignored in density plots -- if they are informative, they should be transformed to a "known unknown" value.
Description of changes
Add a mask in
update_density.Includes