Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Searchable combo boxes in all visualize widgets #4563

Merged
merged 9 commits into from
Apr 10, 2020

Conversation

PrimozGodec
Copy link
Contributor

@PrimozGodec PrimozGodec commented Mar 23, 2020

Description of changes

Now when we have ComboBoxSearch available, it can be used where suitable. With this PR I am adding it to all widgets from the visualize section where a lot of options can be in the combo box - mostly where variables (and values) appear in combo boxes:

  • Tree viewer
  • Distributions
  • Mosaic
  • Sieve diagram
  • Heat Map
  • Pythagorean Forest
  • Pythagorean Tree
  • Silhouette Plot
  • Nomogram
Includes
  • Code changes
  • Tests
  • Documentation

@PrimozGodec PrimozGodec changed the title Searchable combo boxes in all visualize widgets [ENH] Searchable combo boxes in all visualize widgets Mar 23, 2020
@codecov
Copy link

codecov bot commented Mar 23, 2020

Codecov Report

Merging #4563 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4563      +/-   ##
==========================================
- Coverage   83.55%   83.54%   -0.01%     
==========================================
  Files         281      276       -5     
  Lines       56104    55299     -805     
==========================================
- Hits        46877    46199     -678     
+ Misses       9227     9100     -127     

@BlazZupan BlazZupan merged commit 1907459 into biolab:master Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants