[ENH] Searchable combo boxes in all unsupervised widgets #4565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrimozGodec
force-pushed
the
unsupervised-serachable
branch
from
2c539e2
to
c04b3ce
Compare
Codecov Report
@@ Coverage Diff @@
## master #4565 +/- ##
==========================================
- Coverage 83.64% 83.63% -0.02%
==========================================
Files 281 276 -5
Lines 56259 55452 -807
==========================================
- Hits 47060 46375 -685
+ Misses 9199 9077 -122 |
|
Works fine, but did not merge since failing checks. |
PrimozGodec
force-pushed
the
unsupervised-serachable
branch
from
01d6e1e
to
c04b3ce
Compare
PrimozGodec
force-pushed
the
unsupervised-serachable
branch
from
c04b3ce
to
fd32a8d
Compare
|
Now it can be merged. I fixed checks. Also I resolved conflicts for all other three PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Now when we have ComboBoxSearch available, it can be used where suitable. With this PR I am adding it to all widgets from the unsupervised section where a lot of options can be in the combo box - mostly where variables appear in combo boxes:
Includes