[ENH] LinePlot: data info displayed in the status bar #4633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4633 +/- ##
==========================================
- Coverage 83.65% 83.62% -0.03%
==========================================
Files 281 276 -5
Lines 56269 55474 -795
==========================================
- Hits 47072 46391 -681
+ Misses 9197 9083 -114 |
VesnaT
requested changes
Apr 10, 2020
VesnaT
requested changes
Apr 14, 2020
| @@ -543,7 +545,10 @@ def set_data(self, data): | |||
| self.group_view.setEnabled(len(self.group_vars) > 1) | |||
| self.group_var = self.data.domain.class_var \ | |||
| if self.data.domain.has_discrete_class else None | |||
|
|
|||
| self.info.set_input_summary(len(self.data), | |||
| format_summary_details(self.data)) | |||
There was a problem hiding this comment.
I'd rather show the info before the data is changed check_data().
If one, for instance, inputs the zoo dataset, no information is shown.
| no_data_info = "No data on input." | ||
| self.assertEqual(self.widget.infoLabel.text(), no_data_info) | ||
| no_data = "No data on input" | ||
| self.assertEqual(self.widget.info._StateInfo__input_summary.details, no_data) |
There was a problem hiding this comment.
Please keep the line length up to 79 characters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Input/output data info displayed in the status bar.
Includes