[FIX] concurrent: Use a workaround for QObject wrapper deletion #4635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ales-erjavec
force-pushed
the
fixes/task-signal-enqueue
branch
3 times, most recently
from
5c3831d
to
c3c4265
Compare
ales-erjavec
force-pushed
the
fixes/task-signal-enqueue
branch
2 times, most recently
from
db8154c
to
c9eca2e
Compare
Codecov Report
@@ Coverage Diff @@
## master #4635 +/- ##
==========================================
- Coverage 84.18% 84.17% -0.01%
==========================================
Files 277 277
Lines 56463 56455 -8
==========================================
- Hits 47531 47521 -10
- Misses 8932 8934 +2 |
ales-erjavec
force-pushed
the
fixes/task-signal-enqueue
branch
5 times, most recently
from
8606c70
to
9e58a1f
Compare
ales-erjavec
force-pushed
the
fixes/task-signal-enqueue
branch
3 times, most recently
from
6e85285
to
8611330
Compare
ales-erjavec
changed the title
ales-erjavec
force-pushed
the
fixes/task-signal-enqueue
branch
2 times, most recently
from
91857be
to
ad994b6
Compare
ales-erjavec
force-pushed
the
fixes/task-signal-enqueue
branch
8 times, most recently
from
699b7fc
to
5d796ab
Compare
ales-erjavec
changed the title
Allow PyOwned to fully handle the disposal
ales-erjavec
force-pushed
the
fixes/task-signal-enqueue
branch
from
5d796ab
to
8639bba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Ref: gh-4615
Description of changes
Use PyOwned from biolab/orange-widget-base#58
Requires biolab/orange-widget-base#58 is merged and released.Includes