[ENH] owtable: output sorted data #4644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was just a quick look at this issue. Still needs improvements and testing. For example, data is not committed if you change the sorting order. |
|
This must be one of the weirdest [ENH] PRs ever: it adds functionality by removal of 33 lines, and a minor modification of a single line. Kudos. It looks OK, just add the missing signals and tests, when you have time. |
|
Sorry for the delay. I will wrap this up today. Hopefully. |
JakaKokosar
force-pushed
the
table_output_order
branch
from
ca01af1
to
391b899
Compare
Codecov Report
@@ Coverage Diff @@
## master #4644 +/- ##
==========================================
+ Coverage 84.12% 84.14% +0.01%
==========================================
Files 282 277 -5
Lines 57327 56480 -847
==========================================
- Hits 48229 47524 -705
+ Misses 9098 8956 -142 |
|
Is this now still WIP or can I review and merge (if OK)? |
JakaKokosar
force-pushed
the
table_output_order
branch
from
391b899
to
e00056b
Compare
JakaKokosar
changed the title
I added additional tests. If CI passes I think its OK to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #4597
Description of changes
Includes