[FIX] Heatmap: Split by missing values #4686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4686 +/- ##
==========================================
- Coverage 83.70% 83.69% -0.02%
==========================================
Files 280 275 -5
Lines 56436 55644 -792
==========================================
- Hits 47241 46571 -670
+ Misses 9195 9073 -122 |
|
This does not crash anymore. However, it is not what I expected from splitting with missing values: The missing values should be grouped in a separate N/A group (as in colour annotation legend). The behavior that was implemented by this fix can be already achieved by using Select Rows -> is defined. |
|
Now it works as expected. |
3 tasks
|
This works well for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes gh-4684
Description of changes
Includes