[FIX] Feature Statistics: Fix wrong or even crashing selections #4741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4741 +/- ##
==========================================
- Coverage 83.82% 83.82% -0.01%
==========================================
Files 280 276 -4
Lines 56534 55830 -704
==========================================
- Hits 47388 46797 -591
+ Misses 9146 9033 -113 |
janezd
force-pushed
the
featurestatistics-var-settings
branch
from
6c5e0d9
to
05e8a65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Supposedly fixes #4683.
Description of changes
Selection was stored as list of indices and wasn't used in context matching. This resulted in wrong selection when columns were reordered or even crashes when their number was reduced.
Includes