[FIX] UrlReader: shorten TempFile extension #4747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4747 +/- ##
==========================================
- Coverage 83.80% 83.76% -0.04%
==========================================
Files 280 275 -5
Lines 56496 55682 -814
==========================================
- Hits 47344 46640 -704
+ Misses 9152 9042 -110 |
5 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
It can happen that the file name is too long due to the long suffix of the temp-file (the suffix is complete path joined together with _). It invokes File name too long: 'filename' error.
This is one of the issues causing that tests cannot run on cond-forge where file paths are really long conda-forge/orange3-feedstock#77
Description of changes
Temfile does not get a complete name as a suffix but just an ending which makes sure that the correct reader reads the file.
I do not know what exactly is the reason that complete path was provided as a name so I hope that I didn't break anything.
Includes