[FIX] owcsvimport: Handle decimal and thousand separator #4915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... with non C-locale number format.
ales-erjavec
force-pushed
the
fixes/owcsvimport-number-sep
branch
from
c34308a
to
29c053c
Compare
Codecov Report
@@ Coverage Diff @@
## master #4915 +/- ##
==========================================
- Coverage 84.17% 84.10% -0.07%
==========================================
Files 282 278 -4
Lines 57464 56994 -470
==========================================
- Hits 48368 47934 -434
+ Misses 9096 9060 -36 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... with non C-locale number format.
Issue
Fixes gh-4913
Description of changes
Workaround for pandas-dev/pandas#35365
Fallback to float_precision="high" with non C-locale number format.
Includes