[FIX] Fix performance regression in scatterplot #5206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markotoplak
changed the title
Codecov Report
@@ Coverage Diff @@
## master #5206 +/- ##
==========================================
+ Coverage 85.13% 85.14% +0.01%
==========================================
Files 299 299
Lines 60876 60882 +6
==========================================
+ Hits 51824 51837 +13
+ Misses 9052 9045 -7 |
PR biolab#5038 introduced jittering suspension with selection. It introduced a performance regression, because it needlessly updated point positions while the selection was being performed. For example, with 10000 data points, selection was lagging noticeably.
markotoplak
force-pushed
the
fix-scatterplot-selection-performance
branch
from
fb44859
to
7f7e301
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
PR #5038 introduced jittering suspension with selection. It introduced a performance regression, because it needlessly updated point positions while the selection was being performed. For example, with 10000 data points, selection was lagging noticeably.
Includes