[ENH] Transpose: Offload work onto separate thread, remove redundant instance #5314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VesnaT
force-pushed
the
concurrent_transpose
branch
2 times, most recently
from
d5deaf2
to
6bf2a20
Compare
janezd
reviewed
Mar 11, 2021
| attributes = [ContinuousVariable(name) for name in names] | ||
| else: | ||
| places = int(np.ceil(np.log10(n_cols))) if n_cols else 1 | ||
| attributes = [ContinuousVariable(f"{feature_name} {i:0{places}}") | ||
| for i in range(1, n_cols + 1)] | ||
| progress_callback(0.4) |
There was a problem hiding this comment.
I believe the correct value here is 0.418. Please check your calculations again.
VesnaT
force-pushed
the
concurrent_transpose
branch
from
6bf2a20
to
f021c05
Compare
Codecov Report
@@ Coverage Diff @@
## master #5314 +/- ##
=======================================
Coverage 85.35% 85.35%
=======================================
Files 301 301
Lines 62035 62080 +45
=======================================
+ Hits 52950 52991 +41
- Misses 9085 9089 +4 |
markotoplak
reviewed
Apr 1, 2021
markotoplak
reviewed
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #5300
Fixes #5298
Description of changes
Includes