[FIX] Speed-up slow table_to_frame #5413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrimozGodec
force-pushed
the
speedup-table-to-frame
branch
from
ee6806d
to
f92b98e
Compare
|
We started using bottleneck in Orange Spectroscopy. Faster than numpy. Maybe it would also make sense to use that here. |
Codecov Report
@@ Coverage Diff @@
## master #5413 +/- ##
=======================================
Coverage 86.37% 86.37%
=======================================
Files 303 303
Lines 62155 62154 -1
=======================================
Hits 53688 53688
+ Misses 8467 8466 -1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
table_to_frameis slow on large dataset. On dataset with shape (1M, 12) it took ~20s to transform dataframe to table. The reason for slow error is list comprehension used to find out if there is any nan in numeric column.Description of changes
List comprehension is now replaced with NumPy functions.
Transformation on the previously mention dataset now takes ~0.6s
Includes