Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] textimport: Mark encoding errors in the preview #5438

Merged

Conversation

ales-erjavec
Copy link
Contributor

@ales-erjavec ales-erjavec commented May 13, 2021

Issue

Mark encoding errors in the CSV Import preview.

Screen Shot 2021-05-14 at 09 14 48

Related: gh-5436

Description of changes

Mark encoding errors in the preview.

Includes
  • Code changes
  • Tests
  • Documentation

@ales-erjavec ales-erjavec force-pushed the csvimport-indicate-encoding-errors branch from 4030324 to 2875478 Compare May 13, 2021 10:39
@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #5438 (49d3da6) into master (4376a88) will decrease coverage by 0.00%.
The diff coverage is 86.36%.

@@            Coverage Diff             @@
##           master    #5438      +/-   ##
==========================================
- Coverage   86.15%   86.15%   -0.01%     
==========================================
  Files         303      303              
  Lines       61608    61609       +1     
==========================================
- Hits        53080    53078       -2     
- Misses       8528     8531       +3     

@ajdapretnar ajdapretnar merged commit 5b4a89e into biolab:master May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants