Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Scatter plot: Bring discrete attributes functionality back #5440

Merged
merged 1 commit into from
May 21, 2021

Conversation

VesnaT
Copy link
Contributor

@VesnaT VesnaT commented May 14, 2021

Issue

Fixes #4385

Description of changes
Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented May 14, 2021

Codecov Report

Merging #5440 (89ed01b) into master (3773093) will increase coverage by 0.20%.
The diff coverage is 97.87%.

@@            Coverage Diff             @@
##           master    #5440      +/-   ##
==========================================
+ Coverage   86.15%   86.35%   +0.20%     
==========================================
  Files         303      304       +1     
  Lines       61606    61652      +46     
==========================================
+ Hits        53074    53240     +166     
+ Misses       8532     8412     -120     

@markotoplak
Copy link
Member

It might be a good idea to bump the widget settings version.

Also, jittering continuous attributes is not a parameter; before any amount of jittering applied to continuous features. So to keep the same behavior for saved workflows we should set it to True for old workflows.

@lanzagar
Copy link
Contributor

the second bullet in Description of changes says:

revert commit 3773093

Did you copy the wrong commit hash because that one seems unrelated?

Otherwise I tried it and categorical vars work again 👍

@VesnaT
Copy link
Contributor Author

VesnaT commented May 14, 2021

@lanzagar yes, the commit was wrong. I fixed that, thanks for noticing.
@markotoplak you are right, thanks for pointing that out. I'll implement the settings migration.

@VesnaT VesnaT force-pushed the scatter_discrete branch 2 times, most recently from 57c42b0 to 9701f4e Compare May 17, 2021 05:14
@janezd janezd self-assigned this May 21, 2021
@janezd janezd merged commit 96fda39 into biolab:master May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visualizing categorical data in scatter plot with Orange (version > 3.18)
4 participants