[ENH] Use palette colors in more places #5680
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5680 +/- ##
==========================================
+ Coverage 86.13% 86.20% +0.07%
==========================================
Files 316 316
Lines 66388 66616 +228
==========================================
+ Hits 57182 57426 +244
+ Misses 9206 9190 -16 |
ales-erjavec
force-pushed
the
use-palette-colors
branch
2 times, most recently
from
955ec62
to
f657bad
Compare
|
The only fault I can find here is the Correspondence Analysis suddenly showing no points at all. 🤷♀️ The rest is ok. I hope I have tested it well, I wasn't entirely sure what to check. 😅 |
ales-erjavec
force-pushed
the
use-palette-colors
branch
3 times, most recently
from
6f89123
to
7895eeb
Compare
| if self.__brush is not None: | ||
| return QBrush(self.__brush) | ||
| else: | ||
| color = self.palette().color(QPalette.Window) |
There was a problem hiding this comment.
I think this is too dark, at least on my machine. I don't have a better suggestion, except, perhaps, super().brush() (which, for me, apparently uses a transparent background).
There was a problem hiding this comment.
Strange its supposed to be:
There was a problem hiding this comment.
I think I can finally say: Janez, your Qt is a mess. 😆
(i.e. My version is ok, too.)
There was a problem hiding this comment.
My QPalette.Window is black, which it indeed shouldn't be (in light mode on macOS). Any ideas why?
>>> hex(QPalette().color(QPalette.Window).rgb())
'0xff000000'
There was a problem hiding this comment.
Can you post the contents of ~/.config/biolab.si/Orange.iniin particular [application-style] section.
There was a problem hiding this comment.
[application-style]
palette=
style-name=
7895eeb
to
c7f265b
Compare
|
I tried in a new environment. It's still (transparent) black. |
|
On:
|
ales-erjavec
force-pushed
the
use-palette-colors
branch
3 times, most recently
from
4035846
to
ee046d3
Compare
ales-erjavec
force-pushed
the
use-palette-colors
branch
from
ee046d3
to
ff9e445
Compare
|
@ales-erjavec, I downloaded an Orange bundle, replaced the widgets directory with the files from this PR. The legend still has a black background. It looks as something between Qt and Catalina, not my installation of Qt. |
|
As suggested by @markotoplak, I tried creating a fresh user. Still black. |
|
Found it. Works with pyqtgraph 0.12 (the change that was made just to improve performance, it appears: pyqtgraph/pyqtgraph@fd0e2b6). @ales-erjavec, @markotoplak, can we increase the oldest supported version to 0.12? @ales-erjavec, can you add it to this PR? |
Use palette color as the default pen color.
ales-erjavec
force-pushed
the
use-palette-colors
branch
from
ff9e445
to
ca9b973
Compare
I have reset the palette instead so that wont be necessary. |
Issue
Some visualizations use hardcoded colors and do not account for the effective color palette.
Description of changes
Replace use of hardcoded colors with palette colors.
Includes