Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] oweditdomain: Indicate variables in error state #5732

Merged

Conversation

ales-erjavec
Copy link
Contributor

Issue

Ref: gh-5731

Description of changes

Indicate an error state (duplicated name) in the variable list view.

Screenshot 2021-12-10 at 13 24 17

Includes
  • Code changes
  • Tests
  • Documentation

@ajdapretnar
Copy link
Contributor

Exactly what I had in mind. Thanks!

@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #5732 (b24ab28) into master (848fc18) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5732      +/-   ##
==========================================
+ Coverage   86.13%   86.14%   +0.01%     
==========================================
  Files         315      315              
  Lines       66148    66178      +30     
==========================================
+ Hits        56976    57010      +34     
+ Misses       9172     9168       -4     

@ales-erjavec ales-erjavec force-pushed the edit-domain-indicate-duplicated-errors branch from bce90fc to 611b4b0 Compare December 16, 2021 11:47
@ales-erjavec ales-erjavec force-pushed the edit-domain-indicate-duplicated-errors branch from 611b4b0 to b24ab28 Compare December 16, 2021 14:02
@janezd janezd self-assigned this Dec 17, 2021
@janezd
Copy link
Contributor

janezd commented Dec 17, 2021

CountedListModel. Because it was there. So nice.

@janezd janezd merged commit f047100 into biolab:master Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants