Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Silhouette plot text width #5756

Merged
merged 12 commits into from
Jan 7, 2022

Conversation

ales-erjavec
Copy link
Contributor

Issue

Closes gh-5728

Description of changes
  • Do not clip child text items in the text annotations list.
  • Allow the text to be wider (but is still limited to 750px; was 300 before)
  • Generally change how the tool tips are displayed in the GraphicsTextListWidget with associated changes to all its uses (int owheatmap and owdistancemap). Before tool tips were set on individual text items, now the widget responds to QGraphicsSceneHelpEvent).
  • Allow any Discrete it String variable for text Annotations.
  • Also fix misaligned top/bottom axes
Includes
  • Code changes
  • Tests
  • Documentation

@ales-erjavec ales-erjavec force-pushed the silhouette-plot-width branch 3 times, most recently from 562448d to 90b01a6 Compare December 28, 2021 14:23
@codecov
Copy link

codecov bot commented Dec 28, 2021

Codecov Report

Merging #5756 (6645e31) into master (300dbba) will decrease coverage by 0.04%.
The diff coverage is 64.63%.

@@            Coverage Diff             @@
##           master    #5756      +/-   ##
==========================================
- Coverage   86.15%   86.10%   -0.05%     
==========================================
  Files         315      316       +1     
  Lines       66186    66307     +121     
==========================================
+ Hits        57023    57095      +72     
- Misses       9163     9212      +49     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Silhouette Plot: labels out of view + enable discrete labels
2 participants