[ENH] Datetime format selection #5819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrimozGodec
force-pushed
the
datetime-format-selection
branch
from
ee7475f
to
d0b1c89
Compare
PrimozGodec
force-pushed
the
datetime-format-selection
branch
4 times, most recently
from
ad7e45d
to
5d7c550
Compare
Codecov Report
@@ Coverage Diff @@
## master #5819 +/- ##
==========================================
+ Coverage 86.13% 86.23% +0.09%
==========================================
Files 316 315 -1
Lines 66388 66629 +241
==========================================
+ Hits 57182 57456 +274
+ Misses 9206 9173 -33 |
PrimozGodec
force-pushed
the
datetime-format-selection
branch
from
5d7c550
to
55352c2
Compare
PrimozGodec
removed
the
needs discussion
|
This is a great solution and it works well. I have not tested all possible cases, but I tested many and they behave as they should. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Orange's widgets does not support datatime formats other than ISO.
Fixes #5779
Description of changes
Add dropdown with format selection to Edit domain widget
Note
When no year is provided (only day and month) - the last three formats the year will become 1900, since it is the default in python's DateTime and excel too.
Next steps
Implement the same functionality in the File widget --- will be implemented in the separate pull request
Includes