[FIX] Scatter plot: Fix rotation of regression line label #5840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oh yes I have seen this too. I think when it is a negative relationship... |
Codecov Report
@@ Coverage Diff @@
## master #5840 +/- ##
=======================================
Coverage 86.20% 86.20%
=======================================
Files 316 316
Lines 66615 66625 +10
=======================================
+ Hits 57427 57437 +10
Misses 9188 9188 |
|
Tested on pyqtgraph==0.12.3. Even with negative correlation it was not reversed. Tried iris, housing, heart-disease. From this, I will assume it works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #5721.
I've no idea why I though this needs to be rotated. It's been four years; perhaps something changed in pyqtgraph?
Description of changes
Remove rotation.
Includes