[FIX] Calibration: Fix crash on empty folds #5859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janezd
force-pushed
the
calibration-no-foldss
branch
from
cadc612
to
cbe41a5
Compare
Codecov Report
@@ Coverage Diff @@
## master #5859 +/- ##
==========================================
- Coverage 86.28% 86.28% -0.01%
==========================================
Files 315 315
Lines 66797 66798 +1
==========================================
Hits 57636 57636
- Misses 9161 9162 +1 |
VesnaT
reviewed
Feb 25, 2022
| @patch("Orange.widgets.evaluate.owcalibrationplot.ThresholdClassifier") | ||
| @patch("Orange.widgets.evaluate.owcalibrationplot.CalibratedLearner") | ||
| def test_no_folds(self, *_): | ||
| """Warn about omitted points with nan probabiities""" |
There was a problem hiding this comment.
The comment is not correct.
janezd
force-pushed
the
calibration-no-foldss
branch
from
cbe41a5
to
b817423
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #5854.
Description of changes
The problem was essentially in Predictions, which created a malformed instance of
Results. Folds should be[...], notNone.modelstoResultsthat come fromPredictions, so they can be calibrated by Calibrationfolds=Noneif any other widget misbehaves in the same way as PredictionsIncludes