[FIX] Predictions: allow predicting probabilities for classless data #5972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markotoplak
force-pushed
the
fix-prediction-classless
branch
2 times, most recently
from
b1f27c6
to
b37dd21
Compare
markotoplak
changed the title
markotoplak
changed the title
Codecov Report
@@ Coverage Diff @@
## master #5972 +/- ##
=======================================
Coverage 86.40% 86.40%
=======================================
Files 315 315
Lines 67142 67158 +16
=======================================
+ Hits 58014 58029 +15
- Misses 9128 9129 +1 |
janezd
reviewed
May 13, 2022
| widget.setVisible(self.is_discrete_class) | ||
| widget.setVisible(any((slot.predictor.domain.class_var is not None and | ||
| slot.predictor.domain.class_var.is_discrete) | ||
| for slot in self.predictors)) |
There was a problem hiding this comment.
I'd prefer
widget.setVisible(self.is_discrete_class
or any(slot.predictor.domain.has_discrete_class for slot in selt.predictors))There was a problem hiding this comment.
Makes sense! Fixed. Thanks.
Before, combo box for selection of class probabilities was only shown if the data on the input had a dicrete class. Now, the combo is shown as soon as there is one predictor which works with discrete class vars. If class is missing from the file, only model probabilities options are shown there.
markotoplak
force-pushed
the
fix-prediction-classless
branch
from
22d1d6b
to
f86ed47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixed #5970
Description of changes
Before, combo box for selection of class probabilities was only shown if the data on the input had a dicrete class. Now, the combo is shown as soon as there is one predictor which works with discrete class vars. If class is missing from the file, only model probabilities options are shown there.
Includes