Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Handle timezones in Edit Domain #6123

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

PrimozGodec
Copy link
Contributor

@PrimozGodec PrimozGodec commented Sep 5, 2022

Issue

Transforming to Time variable fails when timezone is in strings

Description of changes

Correctly handle timezones in data time

Additionally: First I planned to raise the Pandas version to 1.4 since this version already supports subtracting different timezones. It was impossible since Pandas>=1.4 does not support Python 3.7 anymore, so building documentation fails (by readthedcos) since they build documentation on Python 3.7. Setting different versions of python for rtd is supported by the config file, but it cannot be used with multiple subprojects. We cannot raise the Pandas' version until they start supporting config files for subprojects or building on python 3.8.

Includes
  • Code changes
  • Tests
  • Documentation

@PrimozGodec PrimozGodec changed the title Edit Domain - handle timezones when transforming to datetime [FIX] Edit Domain - handle timezones when transforming to datetime Sep 5, 2022
@janezd janezd assigned janezd and VesnaT and unassigned janezd Sep 9, 2022
@PrimozGodec
Copy link
Contributor Author

/rebase

@codecov
Copy link

codecov bot commented Sep 23, 2022

Codecov Report

Merging #6123 (3e55fff) into master (22565bd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 3e55fff differs from pull request most recent head 7b40090. Consider uploading reports for the commit 7b40090 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6123   +/-   ##
=======================================
  Coverage   86.46%   86.46%           
=======================================
  Files         315      315           
  Lines       67645    67670   +25     
=======================================
+ Hits        58488    58512   +24     
- Misses       9157     9158    +1     

@PrimozGodec PrimozGodec force-pushed the edit-domain-fix-dt branch 4 times, most recently from 5f008d9 to 44c7547 Compare September 23, 2022 07:33
@PrimozGodec PrimozGodec changed the title [FIX] Edit Domain - handle timezones when transforming to datetime [FIX] Handle timezones in Edit Domain and drop tests for Python 3.7 Sep 26, 2022
@PrimozGodec PrimozGodec force-pushed the edit-domain-fix-dt branch 3 times, most recently from d4060c1 to b5d9ca1 Compare September 26, 2022 14:42
@janezd janezd changed the title [FIX] Handle timezones in Edit Domain and drop tests for Python 3.7 [FIX] Handle timezones in Edit Domain Sep 30, 2022
@VesnaT VesnaT merged commit 2979b21 into biolab:master Sep 30, 2022
@PrimozGodec PrimozGodec deleted the edit-domain-fix-dt branch September 30, 2022 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants