[ENH] PCA widget runs a separate thread #6528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markotoplak
force-pushed
the
concurrent-pca
branch
from
2f1faf3
to
9109bc2
Compare
|
/rebase |
biolab-helper
force-pushed
the
concurrent-pca
branch
from
9109bc2
to
e97b4f8
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6528 +/- ##
==========================================
- Coverage 87.68% 87.68% -0.01%
==========================================
Files 321 321
Lines 69371 69405 +34
==========================================
+ Hits 60830 60858 +28
- Misses 8541 8547 +6 |
markotoplak
force-pushed
the
concurrent-pca
branch
2 times, most recently
from
3962110
to
e607e09
Compare
noahnovsak
reviewed
Aug 11, 2023
Code stolen from Learner and the Outliers widget
markotoplak
force-pushed
the
concurrent-pca
branch
from
e607e09
to
e94858f
Compare
noahnovsak
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
For larger data PCA takes longer. Moving computation to a separate thread allows canvas to still be responsive.
Description of changes
The first two commits only refactor the widget to lose some attributes.
This PR only improves the responsiveness of canvas. I did not find any easy ways to interrupt PCA so that is not done here.
Edit: I added a commit that allows for cancelling within preprocessing. Code was stolen from owoutliers and the current implementation in
Learner.Includes