[FIX] Scatter Plot - Handle input features that are hidden in data #6531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6531 +/- ##
=======================================
Coverage 87.68% 87.68%
=======================================
Files 321 321
Lines 69405 69409 +4
=======================================
+ Hits 60858 60864 +6
+ Misses 8547 8545 -2 |
janezd
reviewed
Aug 24, 2023
| if all(attr in self.xy_model for attr in self.attribute_selection_list): | ||
| self.attr_x, self.attr_y = self.attribute_selection_list | ||
| else: | ||
| self.attr_x, self.attr_y = None, None |
There was a problem hiding this comment.
Perhaps it would be better to set attr_x and attr_y to the first two variables in the model, as default? Or did I miss something?
There was a problem hiding this comment.
With this change, I wanted to explicitly show that the user provided the wrong features on the input (so nothing is plotted). Do you think it is better to plot the first two features and ignore the features input in this case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Connected to #6367
When some features are hidden in the data, and those features are present on Scatter Plot's feature input widget fails.
Description of changes
Handle describe scenario and do not plot anyting
Includes