[ENH] SOM: output columns with coordinates and errors #6542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janezd
force-pushed
the
som-output-columns
branch
3 times, most recently
from
6a82c47
to
8f4140f
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6542 +/- ##
========================================
Coverage 87.69% 87.70%
========================================
Files 321 321
Lines 69423 69534 +111
========================================
+ Hits 60879 60982 +103
- Misses 8544 8552 +8 |
janezd
changed the title
janezd
force-pushed
the
som-output-columns
branch
2 times, most recently
from
e2e1a51
to
df17cdb
Compare
markotoplak
reviewed
Aug 24, 2023
markotoplak
reviewed
Aug 24, 2023
janezd
force-pushed
the
som-output-columns
branch
2 times, most recently
from
2111175
to
f0fb80b
Compare
markotoplak
reviewed
Aug 25, 2023
markotoplak
reviewed
Aug 25, 2023
markotoplak
reviewed
Aug 25, 2023
janezd
force-pushed
the
som-output-columns
branch
2 times, most recently
from
9e885ae
to
ac0609e
Compare
markotoplak
removed
the
needs discussion
markotoplak
force-pushed
the
som-output-columns
branch
from
a340d0a
to
065211b
Compare
Added result invaliation into the widget so that tests can get the outputs.
markotoplak
force-pushed
the
som-output-columns
branch
from
065211b
to
e3f2371
Compare
markotoplak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #6540.
Description of changes
Added columns, with lazy values and everything.
To discuss:
som_cellcolumn type.Includes