Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Move build-wheels to Orange repository #6568

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

PrimozGodec
Copy link
Contributor

@PrimozGodec PrimozGodec commented Sep 8, 2023

Issue

Building wheels in separate repository require more manual work. Sorry, @ales-erjavec, for moving away from your wheel repo.

Description of changes

I am moving wheel building here since this change can trigger wheel building by making a release (now an extra commit is required). Also, cibuildwheel settings are moved to pyproject.toml

This PR also makes some other improvements:

  • Wheels are loaded in the release as assets
  • Wheels are automatically uploaded to PyPI
  • No requirement to manually build source (tar.gz) anymore
  • Faster wheel building since it is redistributed among several workers (for each wheel)
  • Stop building wheels for Python 3.8.

Note about the removed test (and file): elftools, which is used as a part of autditwheel on Linux, changed behaviour in how they recognize ELF file (not necessary to have complete header anymore). binary-blob.tab looks like an ELF file with an incomplete folder, so it reads it but fails later and breaks the audit process. Since binary-blob.tab is no longer used in tests with Python 3.11, we can remove it earlier to avoid problems. The problem started to paper with cibuidwheel 2.10 (previously, we built wheels with cibuildwheel 2.9).

TODO: when merged, a Trusted publisher must be added to PyPI.

Includes
  • Code changes
  • Tests
  • Documentation

@PrimozGodec PrimozGodec force-pushed the build-wheels branch 3 times, most recently from 8727c83 to 75fcc1e Compare September 20, 2023 09:24
@ales-erjavec ales-erjavec merged commit f1aa691 into biolab:master Sep 22, 2023
20 of 22 checks passed
@PrimozGodec PrimozGodec deleted the build-wheels branch September 22, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants