Show Webpack compilation errors and exit with non zero code #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denis-ok
force-pushed
the
handle-webpack-compilation-errors
branch
from
54b33bf
to
814ed32
Compare
denis-ok
force-pushed
the
handle-webpack-compilation-errors
branch
from
814ed32
to
a084531
Compare
|
hi @bloodyowl ! do you think there are any blockers, and if there are, is there any way we could help to provide more info (tests, docs) for this PR? Sometimes we change folders or configs in our repo, and as we have a bunch of instances of reshowcase being built, when there are any webpack errors they get swallowed, and it gets hard to debug or understand what's going on, as deploys will succeed just fine. thanks ! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It turns out we don't display any Webpack compilation errors and don't stop a process with a non-zero exit code.
It leads to false-positive builds that fail in runtime.