-
-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show that link to the book is being moderated #3295
Comments
I think these duplicates are linked to a bug (when books circulate between instances). But that doesn't mean that the user shouldn't be warned (I didn't know that he didn't have the moderation information). |
Good catch.
Here's how it works for links to new domains:
P.S. I guess some of those duplicated links could be caused by #2988 and some by UI flaws. |
I know on my instance I've seen a bunch of what looks to be a user being frustrated and not just the bug causing duplicates, this warning sounds very nice! |
I went to see if I could handle this quickly, and there is a line in the FileLinkForm that I would expect to do this (added by Mouse two years ago, per git blame). I confirmed on my own instance by deliberately adding two copies of a link to the last book I read. I never got this warning, and when I approved the domain both appeared. So it seems like this may just be a small bug? Line 49 of https://github.com/bookwyrm-social/bookwyrm/blob/main/bookwyrm/forms/links.py is the exact warning I'd expect to see here, in case somebody else has a chance to get to it before I do! |
#3311 probably fixes accidental duplication. Not sure if it helps to know WHY the link is not being shown yet. |
Is your feature request related to a problem? Please describe.
When adding a link to the book it's very unclear why the link doesn't shows in the list after being added. I often see federated books from other instances with two or more identical links. Most likely users try to add the link twice or more until they're getting frustrated and stop trying.
I did that myself when I added link first time on bookwyrm.social. Only when I set up my own instance I finally understood how it works.
Describe the solution you'd like
We need to show a clear warning that a link is being moderated if it's not going to be shown right away.
The text was updated successfully, but these errors were encountered: