FileLinkForm: fix duplicate check #3311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minnozz
force-pushed
the
filelink-duplicate-check
branch
from
be29b93
to
8d018b8
Compare
dato
approved these changes
Mar 10, 2024
dato
reviewed
Mar 10, 2024
| and models.FileLink.objects.filter( | ||
| url=url, book=book, filetype=filetype | ||
| ).exists() | ||
| models.FileLink.objects.filter(url=url, book=book, filetype=filetype) |
There was a problem hiding this comment.
Not for this PR, but I would propose dropping filetype from this check. Thoughts?
(If file type is wrong and needs updating, the proposed change would ensure the pre-existing link is deleted first.)
There was a problem hiding this comment.
Agreed; I'll change that in a separate PR after this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported @ #3295 (comment)
Tested locally; adding links and duplicate checking works.