fix button text when editing posts #2922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should close bookwyrm-social#2642 and bookwyrm-social#2671. Gives a minimal solution to bookwyrm-social#2668.
I think this wording is more clear.
hughrun
changed the title
hughrun
approved these changes
Jul 31, 2023
There was a problem hiding this comment.
Thanks for this contribution @tararoshan!
This does fix #2642
For #2671 we need to change the heading so that is says "Edit Comment", "Edit Review" etc so that will be a separate PR.
#2668 really needs to move the user out of the edit screen, though I agree this is a partial fix/improvement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Indicate edited post is saved
Should close #2642 and #2671. Gives a minimal solution to #2668.