Type annotations and related changes for connectors #2925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mouse-reeve
approved these changes
Aug 2, 2023
| self.search_url = info.search_url | ||
| self.isbn_search_url = info.isbn_search_url | ||
| self.name = info.name | ||
| self.identifier = info.identifier |
There was a problem hiding this comment.
this is much simpler, thanks for fixing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly type annotations, but a couple of changes to the code to handle potential undefined or None values. Probably wouldn't hurt if someone a bit more familiar with the code would go over it to see whether it makes sense like this.
The
create_edition_from_datamethod seems a bit funny as it expects different arguments in the inventaire connector compared to its parentAbstractConnector, which results in a Union type.